Qfyilyi

I have the following Python code:

class Characters():

    default_player_hp = 100.0

    default_enemy_hp = 100.0

    class Player:

        def __init__(self):

            self.player_health = Characters().default_player_hp

        def update(self):

            self.player_health = Characters().default_player_hp

    class Enemy:

        def __init__(self):

            self.enemy_health = Characters().default_enemy_hp

        def update(self):

            self.enemy_health = Characters().default_enemy_hp

characters = Characters()

player = characters.Player()

while (True):

    characters.default_enemy_hp = round(characters.default_enemy_hp * float(input()) / 10, 3)

    enemy = characters.Enemy()

    enemy.update()

    print(characters.default_enemy_hp, enemy.enemy_health)

The problem is it doesn't change enemy_hp variable (always prints [default_enemy_hp] 100.0).

This snippet:

def update(self):

    self.enemy_health = Characters().default_enemy_hp

makes a new (anonymous) Character object, and sets the current enemy_health attribute of the given Enemy object to 100. That's because new Character's always start with 100 health.

This:

characters.default_enemy_hp = round(characters.default_enemy_hp * float(input()) / 10, 3)

is therefore irrelevant, as enemy.update() will create a new Character object (it will not use the Character object modified above), and just use that new Character object's health (i.e. 100).

If you want to actually update the health, don't work so hard, and just pass in a value and be done with it:

def update(self, new_health):

    self.enemy_health = new_health

Usage:

enemy.update(new_health=15) # or new_health=round(float(input()) / 10, 3), whatever you want.

print(enemy.enemy_health) # outputs 15, as desired

HTH.

P.S. You've got other issues with your code, mostly having to do with creating new Character objects (similar problems to the update issue you've asked about), but this answer only focuses on why update is not working as expected.