Qfyilyi

I am working on a demo project and having a simple but annoying issue with one of my routers.

For the project ids are passed as parameters of the url. The project assign private views to users (routed as /user/:userid/), common views (eg. routed as /group/:grouid/profile) and views that are private to user but that would share data with common views in real time (eg. routed as /group/:groupid/:userid/).

I have currently a simple middleware authorization code to prevent no-registered users to visit group or private user views to see views they are not registered to. A summary of the code is as follows:

authorizationFunctionGroups: function(req, res, next) {

        console.log('in middleware authorizationFunctionGroups');

        console.log('userid', req.params.userid);

     if (!_.isEmpty(registers.groups) && _.get(registers.groups, req.params.groupid)) {

            //console.log(registers.groups[req.params.groupid]);

            console.log(registers.groups[req.params.groupid]['membersuserid']);

            registers.groups[req.params.groupid]['membersuserid'].indexOf(req.params.userid) > -1 ? next() : next(new Error("userid invalid or not in the group"));



        } else {

            next(new Error('Invalid groupid'));



        }

    }

However, when I call the group profile router (/group/:grouid/profile) from some sections of my frontend using the following code:

$('#button1').click(() =>; window.location = '.../group/' + url.pathname.split('/').slice(-2)[0] + '/profile');

the routers get confused, passing my call through the authorization middleware and triggers an error ("userid invalid or not in the group").

The call gets rejected because when the frontend method passes the call to the backend, my routing convention gets stuck as it doesn't recognise the second parameter of that call ("profile") as a user.

The hack I found to solve this is to change my current router /group/:groupid/profile into /group/:groupid/profile/profile, which I dont like.

I have to substitute the above code for:

Middleware

authorizationFunctionGroups: function(req, res, next) {

        console.log('in middleware authorizationFunctionGroups');

        console.log('userid', req.params.userid);

        if (req.params.userid == 'profile') { ///?????????

            res.redirect('/group/' + req.params.groupid + '/profile/profile');

        } else if (!_.isEmpty(registers.groups) && _.get(registers.groups, req.params.groupid)) {

            //console.log(registers.groups[req.params.groupid]);

            console.log(registers.groups[req.params.groupid]['membersuserid']);

            registers.groups[req.params.groupid]['membersuserid'].indexOf(req.params.userid) > -1 ? next() : next(new Error("userid invalid or not in the group"));



        } else {

            next(new Error('Invalid groupid'));



        }

    },

Frontend

$('#button1').click(() =>; window.location = '.../group/' + url.pathname.split('/').slice(-2)[0] + '/profile/profile');

Two Questions

• It is clearly that my main problem is a conventional one. Any advice/resources on how to order/name my routers?




• I am trying to keep a single view for everyone (group/:groupid/profile) instead of creating individual views with same data. However: is this a common best practice in the industry? If not, what is more appropriate?

Thanks in advance for your comments.