Qfyilyi

I wrote a script to transfer only one file at a time and in that script use grep to check for the 226 Transfer complete message. If it finds it, grep returns 0.

ftp -niv < "$2"_ftp.tmp | grep "^226 "

Install the ncftp package. It comes with ncftpget and ncftpput which will each attempt to upload/download a single file, and return with a descriptive error code if there is a problem. See the “Diagnostics” section of the man page.

I think it is easier to run the ftp and check the exit code of ftp if something gone wrong.

I did this like the example below:

# ...

ftp -i -n $HOST 2>&1 1> $FTPLOG << EOF

quote USER $USER

quote PASS $PASSWD

cd $RFOLDER

binary

put $FOLDER/$FILE.sql.Z $FILE.sql.Z

bye

EOF



# Check the ftp util exit code (0 is ok, every else means an error occurred!)

EXITFTP=$?

if test $EXITFTP -ne 0; then echo "$D ERROR FTP" >> $LOG; exit 3; fi

if (grep "^Not connected." $FTPLOG); then echo "$D ERROR FTP CONNECT" >> $LOG; fi 

if (grep "No such file" $FTPLOG); then echo "$D ERROR FTP NO SUCH FILE" >> $LOG; fi 

if (grep "access denied" $FTPLOG ); then echo "$D ERROR FTP ACCESS DENIED" >> $LOG; fi

if (grep "^Please login" $FTPLOG ); then echo "$D ERROR FTP LOGIN" >> $LOG; fi

Edit: To catch errors I grep the output of the ftp command. But it's truly it's not the best solution.

I don't know how familier you are with a Scriptlanguage like Perl, Python or Ruby. They all have a FTP module which you can be used. This enables you to check for errors after each command. Here is a example in Perl:

#!/usr/bin/perl -w

use Net::FTP;

$ftp = Net::FTP->new("example.net") or die "Cannot connect to example.net: $@";

$ftp->login("username", "password") or die "Cannot login ", $ftp->message;

$ftp->cwd("/pub") or die "Cannot change working directory ", $ftp->message;

$ftp->binary;

$ftp->put("foo.bar") or die "Failed to upload ", $ftp->message;

$ftp->quit;

For this logic to work user need to redirect STDERR as well from ftp command as below

ftp -i -n $HOST >$FTPLOG 2>&1 << EOF

Below command will always assign 0 (success) as because ftp command wont return success or failure. So user should not depend on it

EXITFTP=$?

lame answer I know, but how about getting the ftp sources and see for yourself

I like the solution from Anurag, for the bytes transfered problem I have extended the command with grep -v "bytes"

ie

grep "^530" ftp_out2.txt | grep -v "byte"

-instead of 530 you can use all the error codes as Anurag did.

You said you wanted to FTP the file there, but you didn't say whether or not regular BSD FTP client was the only way you wanted to get it there. BSD FTP doesn't give you a return code for error conditions necessitating all that parsing, but there are a whole series of other Unix programs that can be used to transfer files by FTP if you or your administrator will install them. I will give you some examples of ways to transfer a file by FTP while still catching all error conditions with little amounts of code.

FTPUSER is your ftp user login name

FTPPASS is your ftp password

FILE is the local file you want to upload without any path info (eg file1.txt, not /whatever/file1.txt or whatever/file1.txt

FTPHOST is the remote machine you want to FTP to

REMOTEDIR is an ABSOLUTE PATH to the location on the remote machine you want to upload to

Here are the examples:

curl --user $FTPUSER:$FTPPASS -T $FILE ftp://$FTPHOST/%2f$REMOTEDIR

ftp-upload --host $FTPHOST --user $FTPUSER --password $FTPPASS --as $REMOTEDIR/$FILE $FILE

tnftp -u ftp://$FTPUSER:$FTPPASS@$FTPHOST/%2f$REMOTEDIR/$FILE $FILE

wput $FILE ftp://$FTPUSER:$FTPPASS@$FTPHOST/%2f$REMOTEDIR/$FILE

All of these programs will return a nonzero exit code if anything at all goes wrong, along with text that indicates what failed. You can test for this and then do whatever you want with the output, log it, email it, etc as you wished.

Please note the following however:

1. "%2f" is used in URLs to indicate that the following path is an absolute path on the remote machine. However, if your FTP server chroots you, you won't be able to bypass this.




2. for the commands above that use an actual URL (ftp://etc) to the server with the user and password embedded in it, the username and password MUST be URL-encoded if it contains special characters.




3. In some cases you can be flexible with the remote directory being absolute and local file being just the plain filename once you are familiar with the syntax of each program. You might just have to add a local directory environment variable or just hardcode everything.




4. IF you really, absolutely MUST use regular FTP client, one way you can test for failure is by, inside your script, including first a command that PUTs the file, followed by another that does a GET of the same file returning it under a different name. After FTP exits, simply test for the existence of the downloaded file in your shell script, or even checksum it against the original to make sure it transferred correctly. Yeah that stinks, but in my opinion it is better to have code that is easy to read than do tons of parsing for every possible error condition. BSD FTP is just not all that great.

Here is what I finally went with. Thanks for all the help. All the answers help lead me in the right direction.
It may be a little overkill, checking both the result and the log, but it should cover all of the bases.

echo "open ftp_ip

pwd

binary    

lcd /out

cd /in

mput datafile.csv

quit"|ftp -iv > ftpreturn.log



ftpresult=$?



bytesindatafile=`wc -c datafile.csv | cut -d " " -f 1`    

bytestransferred=`grep -e '^[0-9]* bytes sent' ftpreturn.log | cut -d " " -f 1`    

ftptransfercomplete=`grep -e '226 ' ftpreturn.log | cut -d " " -f 1`



echo "-- FTP result code: $ftpresult" >> ftpreturn.log

echo "-- bytes in datafile: $bytesindatafile bytes" >> ftpreturn.log

echo "-- bytes transferred: $bytestransferred bytes sent" >> ftpreturn.log



if [ "$ftpresult" != "0" ] || [ "$bytestransferred" != "$bytesindatafile" ] || ["$ftptransfercomplete" != "226" ]    

then    

  echo "-- *abend* FTP Error occurred" >> ftpreturn.log    

  mailx -s 'FTP error' `cat email.lst` < ftpreturn.log

else    

  echo "-- file sent via ftp successfully" >> ftpreturn.log    

fi

Why not just store all output from the command to a log file, then check the return code from the command and, if it's not 0, send the log file in the email?