Js slower in Photoshop than in Chrome. Can I make two for loops faster?











up vote
0
down vote

favorite












The following code generates random points(x,y) and then for each point it splits the canvas (one square) into four. With the next point in the iteration it searches for the square where the point is located and splits it into four smaller squares - up to a certain square size.



The problem is it is very fast to run in Chrome and extremely slow in Ps (for 11k points it takes 2 seconds in Chrome and 30 minutes in Ps! For 1k points it takes around 10 secs in Ps.



Is there any better rewriting to this? btw, Ps doesn't support ES5



var squares = ;
var canvaswidth = app.activeDocument.width.as("px");
var canvasheight = app.activeDocument.height.as("px");
squares.push([{
x: 0,
y: 0
}, {
x: canvaswidth,
y: 0
}, {
x: canvaswidth,
y: canvasheight
}, {
x: 0,
y: canvasheight
}])
vertices = ;
for (i = 0; i < 8000; i++) {
vertices.push({
x: Math.floor(Math.random() * canvaswidth),
y: Math.floor(Math.random() * canvasheight)
})
}
var t0 = new Date().getTime();
var minsquaresize = 24;
for (v = 0; v < vertices.length; v++) {
if (v > 0 && Math.abs(vertices[v].x - vertices[v - 1].x) > minsquaresize && Math.abs(vertices[v].y - vertices[v - 1].y) > minsquaresize) {
r = 2;

for (s = 0; s < squares.length; s++) {

var squares_s = squares[s];
if (squares_s != undefined && vertices[v].x >= squares_s[0].x && vertices[v].x <= squares_s[2].x && vertices[v].y >= squares_s[0].y && vertices[v].y <= squares_s[2].y && squares_s[1].x - squares_s[0].x > minsquaresize && squares_s[3].y - squares_s[0].y > minsquaresize) {
var s1p1 = {
x: Math.round(squares_s[0].x),
y: Math.round(squares_s[0].y)
};
var s1p2 = {
x: Math.round((squares_s[0].x + squares_s[1].x) / 2),
y: Math.round((squares_s[0].y + squares_s[1].y) / 2)
};
var s1p3 = {
x: Math.round(((squares_s[1].x - squares_s[0].x) / r) + squares_s[0].x),
y: Math.round(((squares_s[3].y - squares_s[0].y) / r) + squares_s[0].y)
}
var s1p4 = {
x: (squares_s[0].x + squares_s[3].x) / 2,
y: Math.round((squares_s[0].y + squares_s[3].y) / 2)
}
var s2p2 = {
x: squares_s[1].x,
y: squares_s[1].y
}
var s2p3 = {
x: Math.round((squares_s[1].x + squares_s[2].x) / 2),
y: Math.round((squares_s[1].y + squares_s[2].y) / 2)
}
var s3p3 = {
x: squares_s[2].x,
y: squares_s[2].y
}
var s3p4 = {
x: Math.round((squares_s[2].x + squares_s[3].x) / 2),
y: Math.round(Math.round((squares_s[2].y + squares_s[3].y) / 2))
}
var s4p4 = {
x: squares_s[3].x,
y: squares_s[3].y
}
//alert(s4p4.y)
delete squares[s];
squares.push([s1p1, s1p2, s1p3, s1p4])
squares.push([s1p2, s2p2, s2p3, s1p3])
squares.push([s1p3, s2p3, s3p3, s3p4])
squares.push([s1p4, s1p3, s3p4, s4p4])
break;
}
}
}
}
var t1 = new Date().getTime() - t0;
alert("time: "+t1)









share|improve this question




























    up vote
    0
    down vote

    favorite












    The following code generates random points(x,y) and then for each point it splits the canvas (one square) into four. With the next point in the iteration it searches for the square where the point is located and splits it into four smaller squares - up to a certain square size.



    The problem is it is very fast to run in Chrome and extremely slow in Ps (for 11k points it takes 2 seconds in Chrome and 30 minutes in Ps! For 1k points it takes around 10 secs in Ps.



    Is there any better rewriting to this? btw, Ps doesn't support ES5



    var squares = ;
    var canvaswidth = app.activeDocument.width.as("px");
    var canvasheight = app.activeDocument.height.as("px");
    squares.push([{
    x: 0,
    y: 0
    }, {
    x: canvaswidth,
    y: 0
    }, {
    x: canvaswidth,
    y: canvasheight
    }, {
    x: 0,
    y: canvasheight
    }])
    vertices = ;
    for (i = 0; i < 8000; i++) {
    vertices.push({
    x: Math.floor(Math.random() * canvaswidth),
    y: Math.floor(Math.random() * canvasheight)
    })
    }
    var t0 = new Date().getTime();
    var minsquaresize = 24;
    for (v = 0; v < vertices.length; v++) {
    if (v > 0 && Math.abs(vertices[v].x - vertices[v - 1].x) > minsquaresize && Math.abs(vertices[v].y - vertices[v - 1].y) > minsquaresize) {
    r = 2;

    for (s = 0; s < squares.length; s++) {

    var squares_s = squares[s];
    if (squares_s != undefined && vertices[v].x >= squares_s[0].x && vertices[v].x <= squares_s[2].x && vertices[v].y >= squares_s[0].y && vertices[v].y <= squares_s[2].y && squares_s[1].x - squares_s[0].x > minsquaresize && squares_s[3].y - squares_s[0].y > minsquaresize) {
    var s1p1 = {
    x: Math.round(squares_s[0].x),
    y: Math.round(squares_s[0].y)
    };
    var s1p2 = {
    x: Math.round((squares_s[0].x + squares_s[1].x) / 2),
    y: Math.round((squares_s[0].y + squares_s[1].y) / 2)
    };
    var s1p3 = {
    x: Math.round(((squares_s[1].x - squares_s[0].x) / r) + squares_s[0].x),
    y: Math.round(((squares_s[3].y - squares_s[0].y) / r) + squares_s[0].y)
    }
    var s1p4 = {
    x: (squares_s[0].x + squares_s[3].x) / 2,
    y: Math.round((squares_s[0].y + squares_s[3].y) / 2)
    }
    var s2p2 = {
    x: squares_s[1].x,
    y: squares_s[1].y
    }
    var s2p3 = {
    x: Math.round((squares_s[1].x + squares_s[2].x) / 2),
    y: Math.round((squares_s[1].y + squares_s[2].y) / 2)
    }
    var s3p3 = {
    x: squares_s[2].x,
    y: squares_s[2].y
    }
    var s3p4 = {
    x: Math.round((squares_s[2].x + squares_s[3].x) / 2),
    y: Math.round(Math.round((squares_s[2].y + squares_s[3].y) / 2))
    }
    var s4p4 = {
    x: squares_s[3].x,
    y: squares_s[3].y
    }
    //alert(s4p4.y)
    delete squares[s];
    squares.push([s1p1, s1p2, s1p3, s1p4])
    squares.push([s1p2, s2p2, s2p3, s1p3])
    squares.push([s1p3, s2p3, s3p3, s3p4])
    squares.push([s1p4, s1p3, s3p4, s4p4])
    break;
    }
    }
    }
    }
    var t1 = new Date().getTime() - t0;
    alert("time: "+t1)









    share|improve this question


























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      The following code generates random points(x,y) and then for each point it splits the canvas (one square) into four. With the next point in the iteration it searches for the square where the point is located and splits it into four smaller squares - up to a certain square size.



      The problem is it is very fast to run in Chrome and extremely slow in Ps (for 11k points it takes 2 seconds in Chrome and 30 minutes in Ps! For 1k points it takes around 10 secs in Ps.



      Is there any better rewriting to this? btw, Ps doesn't support ES5



      var squares = ;
      var canvaswidth = app.activeDocument.width.as("px");
      var canvasheight = app.activeDocument.height.as("px");
      squares.push([{
      x: 0,
      y: 0
      }, {
      x: canvaswidth,
      y: 0
      }, {
      x: canvaswidth,
      y: canvasheight
      }, {
      x: 0,
      y: canvasheight
      }])
      vertices = ;
      for (i = 0; i < 8000; i++) {
      vertices.push({
      x: Math.floor(Math.random() * canvaswidth),
      y: Math.floor(Math.random() * canvasheight)
      })
      }
      var t0 = new Date().getTime();
      var minsquaresize = 24;
      for (v = 0; v < vertices.length; v++) {
      if (v > 0 && Math.abs(vertices[v].x - vertices[v - 1].x) > minsquaresize && Math.abs(vertices[v].y - vertices[v - 1].y) > minsquaresize) {
      r = 2;

      for (s = 0; s < squares.length; s++) {

      var squares_s = squares[s];
      if (squares_s != undefined && vertices[v].x >= squares_s[0].x && vertices[v].x <= squares_s[2].x && vertices[v].y >= squares_s[0].y && vertices[v].y <= squares_s[2].y && squares_s[1].x - squares_s[0].x > minsquaresize && squares_s[3].y - squares_s[0].y > minsquaresize) {
      var s1p1 = {
      x: Math.round(squares_s[0].x),
      y: Math.round(squares_s[0].y)
      };
      var s1p2 = {
      x: Math.round((squares_s[0].x + squares_s[1].x) / 2),
      y: Math.round((squares_s[0].y + squares_s[1].y) / 2)
      };
      var s1p3 = {
      x: Math.round(((squares_s[1].x - squares_s[0].x) / r) + squares_s[0].x),
      y: Math.round(((squares_s[3].y - squares_s[0].y) / r) + squares_s[0].y)
      }
      var s1p4 = {
      x: (squares_s[0].x + squares_s[3].x) / 2,
      y: Math.round((squares_s[0].y + squares_s[3].y) / 2)
      }
      var s2p2 = {
      x: squares_s[1].x,
      y: squares_s[1].y
      }
      var s2p3 = {
      x: Math.round((squares_s[1].x + squares_s[2].x) / 2),
      y: Math.round((squares_s[1].y + squares_s[2].y) / 2)
      }
      var s3p3 = {
      x: squares_s[2].x,
      y: squares_s[2].y
      }
      var s3p4 = {
      x: Math.round((squares_s[2].x + squares_s[3].x) / 2),
      y: Math.round(Math.round((squares_s[2].y + squares_s[3].y) / 2))
      }
      var s4p4 = {
      x: squares_s[3].x,
      y: squares_s[3].y
      }
      //alert(s4p4.y)
      delete squares[s];
      squares.push([s1p1, s1p2, s1p3, s1p4])
      squares.push([s1p2, s2p2, s2p3, s1p3])
      squares.push([s1p3, s2p3, s3p3, s3p4])
      squares.push([s1p4, s1p3, s3p4, s4p4])
      break;
      }
      }
      }
      }
      var t1 = new Date().getTime() - t0;
      alert("time: "+t1)









      share|improve this question















      The following code generates random points(x,y) and then for each point it splits the canvas (one square) into four. With the next point in the iteration it searches for the square where the point is located and splits it into four smaller squares - up to a certain square size.



      The problem is it is very fast to run in Chrome and extremely slow in Ps (for 11k points it takes 2 seconds in Chrome and 30 minutes in Ps! For 1k points it takes around 10 secs in Ps.



      Is there any better rewriting to this? btw, Ps doesn't support ES5



      var squares = ;
      var canvaswidth = app.activeDocument.width.as("px");
      var canvasheight = app.activeDocument.height.as("px");
      squares.push([{
      x: 0,
      y: 0
      }, {
      x: canvaswidth,
      y: 0
      }, {
      x: canvaswidth,
      y: canvasheight
      }, {
      x: 0,
      y: canvasheight
      }])
      vertices = ;
      for (i = 0; i < 8000; i++) {
      vertices.push({
      x: Math.floor(Math.random() * canvaswidth),
      y: Math.floor(Math.random() * canvasheight)
      })
      }
      var t0 = new Date().getTime();
      var minsquaresize = 24;
      for (v = 0; v < vertices.length; v++) {
      if (v > 0 && Math.abs(vertices[v].x - vertices[v - 1].x) > minsquaresize && Math.abs(vertices[v].y - vertices[v - 1].y) > minsquaresize) {
      r = 2;

      for (s = 0; s < squares.length; s++) {

      var squares_s = squares[s];
      if (squares_s != undefined && vertices[v].x >= squares_s[0].x && vertices[v].x <= squares_s[2].x && vertices[v].y >= squares_s[0].y && vertices[v].y <= squares_s[2].y && squares_s[1].x - squares_s[0].x > minsquaresize && squares_s[3].y - squares_s[0].y > minsquaresize) {
      var s1p1 = {
      x: Math.round(squares_s[0].x),
      y: Math.round(squares_s[0].y)
      };
      var s1p2 = {
      x: Math.round((squares_s[0].x + squares_s[1].x) / 2),
      y: Math.round((squares_s[0].y + squares_s[1].y) / 2)
      };
      var s1p3 = {
      x: Math.round(((squares_s[1].x - squares_s[0].x) / r) + squares_s[0].x),
      y: Math.round(((squares_s[3].y - squares_s[0].y) / r) + squares_s[0].y)
      }
      var s1p4 = {
      x: (squares_s[0].x + squares_s[3].x) / 2,
      y: Math.round((squares_s[0].y + squares_s[3].y) / 2)
      }
      var s2p2 = {
      x: squares_s[1].x,
      y: squares_s[1].y
      }
      var s2p3 = {
      x: Math.round((squares_s[1].x + squares_s[2].x) / 2),
      y: Math.round((squares_s[1].y + squares_s[2].y) / 2)
      }
      var s3p3 = {
      x: squares_s[2].x,
      y: squares_s[2].y
      }
      var s3p4 = {
      x: Math.round((squares_s[2].x + squares_s[3].x) / 2),
      y: Math.round(Math.round((squares_s[2].y + squares_s[3].y) / 2))
      }
      var s4p4 = {
      x: squares_s[3].x,
      y: squares_s[3].y
      }
      //alert(s4p4.y)
      delete squares[s];
      squares.push([s1p1, s1p2, s1p3, s1p4])
      squares.push([s1p2, s2p2, s2p3, s1p3])
      squares.push([s1p3, s2p3, s3p3, s3p4])
      squares.push([s1p4, s1p3, s3p4, s4p4])
      break;
      }
      }
      }
      }
      var t1 = new Date().getTime() - t0;
      alert("time: "+t1)






      javascript scripting adobe photoshop






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 22 at 12:19

























      asked Nov 22 at 8:12









      CristianC

      869




      869
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          0
          down vote













          Managed a significant performance increase by looping the squares in reverse.
          So normally it was:



          for(vertices length, v++){
          for(squares length, s++){
          if vertex is within square then delete square from square array, split square into 4 equal squares and add them to array
          }
          }


          Vertices are collected from a path, so vertex 4 will probably be close to vertex 3 so probably in the area of the last squares created from vertex 3 - in the end of the squares array. So:



          for(var s = squares.length; s--;){...}


          This works much faster (maybe 10 times). Strange that it is also faster with randomly placed vertices.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53426437%2fjs-slower-in-photoshop-than-in-chrome-can-i-make-two-for-loops-faster%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            0
            down vote













            Managed a significant performance increase by looping the squares in reverse.
            So normally it was:



            for(vertices length, v++){
            for(squares length, s++){
            if vertex is within square then delete square from square array, split square into 4 equal squares and add them to array
            }
            }


            Vertices are collected from a path, so vertex 4 will probably be close to vertex 3 so probably in the area of the last squares created from vertex 3 - in the end of the squares array. So:



            for(var s = squares.length; s--;){...}


            This works much faster (maybe 10 times). Strange that it is also faster with randomly placed vertices.






            share|improve this answer

























              up vote
              0
              down vote













              Managed a significant performance increase by looping the squares in reverse.
              So normally it was:



              for(vertices length, v++){
              for(squares length, s++){
              if vertex is within square then delete square from square array, split square into 4 equal squares and add them to array
              }
              }


              Vertices are collected from a path, so vertex 4 will probably be close to vertex 3 so probably in the area of the last squares created from vertex 3 - in the end of the squares array. So:



              for(var s = squares.length; s--;){...}


              This works much faster (maybe 10 times). Strange that it is also faster with randomly placed vertices.






              share|improve this answer























                up vote
                0
                down vote










                up vote
                0
                down vote









                Managed a significant performance increase by looping the squares in reverse.
                So normally it was:



                for(vertices length, v++){
                for(squares length, s++){
                if vertex is within square then delete square from square array, split square into 4 equal squares and add them to array
                }
                }


                Vertices are collected from a path, so vertex 4 will probably be close to vertex 3 so probably in the area of the last squares created from vertex 3 - in the end of the squares array. So:



                for(var s = squares.length; s--;){...}


                This works much faster (maybe 10 times). Strange that it is also faster with randomly placed vertices.






                share|improve this answer












                Managed a significant performance increase by looping the squares in reverse.
                So normally it was:



                for(vertices length, v++){
                for(squares length, s++){
                if vertex is within square then delete square from square array, split square into 4 equal squares and add them to array
                }
                }


                Vertices are collected from a path, so vertex 4 will probably be close to vertex 3 so probably in the area of the last squares created from vertex 3 - in the end of the squares array. So:



                for(var s = squares.length; s--;){...}


                This works much faster (maybe 10 times). Strange that it is also faster with randomly placed vertices.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 22 at 13:05









                CristianC

                869




                869






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53426437%2fjs-slower-in-photoshop-than-in-chrome-can-i-make-two-for-loops-faster%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    What visual should I use to simply compare current year value vs last year in Power BI desktop

                    Alexandru Averescu

                    Trompette piccolo