Qfyilyi

I want to use environment variables to configure the HttpModule per module, from the docs I can use the configuration like this:

@Module({

  imports: [HttpModule.register({

    timeout: 5000,

    maxRedirects: 5,

  })],

})

But I don't know what is the best practice to inclue a baseURL from environment vairable (or a config service), for example like this:

@Module({

imports: [HttpModule.register({

    baseURL:  this.config.get('API_BASE_URL'),

    timeout: 5000,

    maxRedirects: 5,

})],

The this.config is undefined here cause it's out of class.

What is the best practice to set baseURL from environment variables (or config service)?

This problem was discussed in this issue. For the nestjs modules like the TypeOrmModule or the MongooseModule the following pattern was implemented.

The useFactory method returns the configuration object.

TypeOrmModule.forRootAsync({

  imports:[ConfigModule],

  useFactory: async (configService: ConfigService) => ({

    type: configService.getDatabase()

  }),

    inject: [ConfigService]

}),

Although Kamil wrote

Above convention is now applied in all nest modules and will be
treated as a best practice (+recommendation for 3rd party modules).
More in the docs

it does not seem to be implemented for the HttpModule yet, but maybe you can open an issue about it. There are also some other suggestions in the issue I mentioned above.

Also have a look at the official docs with best practices on how to implement a ConfigService.