Qfyilyi

I'm currently carrying out a task, where I have to create a software development solution to allow managers to add new staff and tasks. for this, I have an ArrayList called staffMembers, which takes name, grade and salary as parameters and an array list called tasksToDo, which takes taskName, taskGrade and taskHours as parameters.

One of the requirements is to enable the managers to click a JButton and this will only display staffMembers whose grade is equal to or greater than the taskGrade for the selected task (this is selected using JComboBox). the result will be displayed in a JTable.

private void jButtonSelectTaskActionPerformed(java.awt.event.ActionEvent evt) {                                                  



    int num1 = this.jobGrade;//use the int supplied 

    //by user

    String colNames = {"Name", "Grade", "Montlhly Salary/Hourly Rate"};

    DefaultTableModel model = (DefaultTableModel) staffByTaskGradeTable.getModel();



    Object rowData = new Object[staffMembers.size()][3];

    for (int i = 0; i < staffMembers.size(); i++) {

        if (staffMembers.get(i).grade > num1) {



            rowData[i][0] = staffMembers.get(i).name;

            rowData[i][1] = staffMembers.get(i).grade;

            rowData[i][2] = staffMembers.get(i).getCost();



            model.setDataVector(rowData, colNames);

        }

    }

However, the code above doesn't give the required result and I hoped someone my be able to point me in the right direction.

You are setting model.setDataVector each time you get a match. Besides, (sm.grade > num1) must have >= comparing, if you want equal or greater grade.

Also, you shouldn't use get(i) multiple times, do it once and store in a variable for any further actions. Or just use forEach.(Or lambda if You use java8+)

private void jButtonSelectTaskActionPerformed(java.awt.event.ActionEvent evt) {                                                  



int num1 = this.jobGrade;//use the int supplied 

//by user

String colNames = {"Name", "Grade", "Montlhly Salary/Hourly Rate"};

DefaultTableModel model = (DefaultTableModel) staffByTaskGradeTable.getModel();



List<Object> rowData = new ArrayList<>();

Object member;

for (StaffMember sm:staffMembers) {

    if (sm.grade >= num1) {

        rowData.add(new Object {(Object)sm.name, (Object)sm.grade, 

                 (Object)sm.getCost()});

    }

}

model.setDataVector(rowData.toArray(new Object[rowData.size()]), colNames);

Object rowData = new Object[staffMembers.size()][3];

for (int i = 0; i < staffMembers.size(); i++) {

    if (staffMembers.get(i).grade > num1) {



        rowData[i][0] = staffMembers.get(i).name;

        rowData[i][1] = staffMembers.get(i).grade;

        rowData[i][2] = staffMembers.get(i).getCost();



        model.setDataVector(rowData, colNames);

    }

}

Don't use code like the above. You are reserving space in your 2D array assuming all staff members are selected. What if only the first and last meet your criteria? You will have a bunch of empty lines in the middle of the table.

Instead you should just dynamically add a row of data to the model when your specific criteria is met. Something like:

String colNames = {"Name", "Grade", "Montlhly Salary/Hourly Rate"};

DefaultTableModel model = new DefaultTableModel(colNames, 0); // create empty model





for (int i = 0; i < staffMembers.size(); i++) {

    if (staffMembers.get(i).grade > num1) {

        Vector<Object> row = new Vector<Object>(3);

        row.add( staffMembers.get(i).name );

        row.add( staffMembers.get(i).grade );

        row.add( staffMembers.get(i).getCost() );

        model.addRow( row );

    }

}



staffByTaskGradeTable.setModel( model );

You still need to debug why your "if condition" doesn't do what you expect.

Or how do you know that you are replacing the data in the model of the table that is visible on the frame. Maybe you have to instance of the table and only one is visible on the frame. A simple test it to just replace all the code in your method with:

DefaultTableModel model = new DefaultTableModel(5, 5); 

staffByTaskGradeTable.setModel(model);

Now you should see an empty table with 5 row and 5 columns. If this works the problem is with your "if condition". The data is not what you expect.