Fluent Validation not validating on request
I'm trying to set up fluent validation for .net core.
I've been following a guide which tells me:
* Add the aspnetcore fluent validation package
* Make your rules in a custom validator
* Register it at startup.
I'm trying to get it working, and it only works when in my code I instantiate an instance of the validator and then validate. I want to validate it on the request coming through before it even gets there!
Why isn't this working?
My code so far:
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]GraphQlQuery query)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
Startup.cs
services.AddMvc(opt => opt.Filters.Add(typeof(ValidatorActionFilter)))
.AddFluentValidation(x => x.RegisterValidatorsFromAssemblyContaining<AccountValidator>())
Validator:
public class AccountValidator : AbstractValidator<Account>
{
public AccountValidator()
{
RuleFor(c => c.CreditLimit)
.LessThan(0).WithMessage("Credit Limit can not be less than 0")
.GreaterThan(100).WithMessage("Credit Limit can not be greater than 100");
}
}
It works when I do this though:
var accountValidator = new AccountValidator();
x.Add(accountValidator.Validate(new Account { CreditLimit = 999}));
I've updated the object, so this should be getting hit. I added the CreditLimit as 101.
Why isn't this working in the pipeline when my api gets hit?
c# asp.net-core fluentvalidation
asked Nov 22 at 23:59
magna_nz
4711822
add a comment |
I'm trying to set up fluent validation for .net core.
I've been following a guide which tells me:
* Add the aspnetcore fluent validation package
* Make your rules in a custom validator
* Register it at startup.
I'm trying to get it working, and it only works when in my code I instantiate an instance of the validator and then validate. I want to validate it on the request coming through before it even gets there!
Why isn't this working?
My code so far:
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]GraphQlQuery query)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
Startup.cs
services.AddMvc(opt => opt.Filters.Add(typeof(ValidatorActionFilter)))
.AddFluentValidation(x => x.RegisterValidatorsFromAssemblyContaining<AccountValidator>())
Validator:
public class AccountValidator : AbstractValidator<Account>
{
public AccountValidator()
{
RuleFor(c => c.CreditLimit)
.LessThan(0).WithMessage("Credit Limit can not be less than 0")
.GreaterThan(100).WithMessage("Credit Limit can not be greater than 100");
}
}
It works when I do this though:
var accountValidator = new AccountValidator();
x.Add(accountValidator.Validate(new Account { CreditLimit = 999}));
I've updated the object, so this should be getting hit. I added the CreditLimit as 101.
Why isn't this working in the pipeline when my api gets hit?
c# asp.net-core fluentvalidation
asked Nov 22 at 23:59
magna_nz
4711822
add a comment |
I'm trying to set up fluent validation for .net core.
I've been following a guide which tells me:
* Add the aspnetcore fluent validation package
* Make your rules in a custom validator
* Register it at startup.
I'm trying to get it working, and it only works when in my code I instantiate an instance of the validator and then validate. I want to validate it on the request coming through before it even gets there!
Why isn't this working?
My code so far:
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]GraphQlQuery query)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
Startup.cs
services.AddMvc(opt => opt.Filters.Add(typeof(ValidatorActionFilter)))
.AddFluentValidation(x => x.RegisterValidatorsFromAssemblyContaining<AccountValidator>())
Validator:
public class AccountValidator : AbstractValidator<Account>
{
public AccountValidator()
{
RuleFor(c => c.CreditLimit)
.LessThan(0).WithMessage("Credit Limit can not be less than 0")
.GreaterThan(100).WithMessage("Credit Limit can not be greater than 100");
}
}
It works when I do this though:
var accountValidator = new AccountValidator();
x.Add(accountValidator.Validate(new Account { CreditLimit = 999}));
I've updated the object, so this should be getting hit. I added the CreditLimit as 101.
Why isn't this working in the pipeline when my api gets hit?
c# asp.net-core fluentvalidation
asked Nov 22 at 23:59
magna_nz
4711822
I'm trying to set up fluent validation for .net core.
I've been following a guide which tells me:
* Add the aspnetcore fluent validation package
* Make your rules in a custom validator
* Register it at startup.
I'm trying to get it working, and it only works when in my code I instantiate an instance of the validator and then validate. I want to validate it on the request coming through before it even gets there!
Why isn't this working?
My code so far:
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]GraphQlQuery query)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
Startup.cs
services.AddMvc(opt => opt.Filters.Add(typeof(ValidatorActionFilter)))
.AddFluentValidation(x => x.RegisterValidatorsFromAssemblyContaining<AccountValidator>())
Validator:
public class AccountValidator : AbstractValidator<Account>
{
public AccountValidator()
{
RuleFor(c => c.CreditLimit)
.LessThan(0).WithMessage("Credit Limit can not be less than 0")
.GreaterThan(100).WithMessage("Credit Limit can not be greater than 100");
}
}
It works when I do this though:
var accountValidator = new AccountValidator();
x.Add(accountValidator.Validate(new Account { CreditLimit = 999}));
I've updated the object, so this should be getting hit. I added the CreditLimit as 101.
Why isn't this working in the pipeline when my api gets hit?
c# asp.net-core fluentvalidation
c# asp.net-core fluentvalidation
asked Nov 22 at 23:59
magna_nz
4711822
asked Nov 22 at 23:59
magna_nz
4711822
asked Nov 22 at 23:59
magna_nz
4711822
asked Nov 22 at 23:59
magna_nz
4711822
asked Nov 22 at 23:59
magna_nz
4711822
4711822
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
FluentValidation works validating the entry parameters of the Endpoint. In your case this should work if you want to validate the Account from the body. If you want to validate the Query you have to write a QueryValidator.
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]Account account)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
answered Nov 23 at 0:17
German Casares
726
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53439241%2ffluent-validation-not-validating-on-request%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
FluentValidation works validating the entry parameters of the Endpoint. In your case this should work if you want to validate the Account from the body. If you want to validate the Query you have to write a QueryValidator.
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]Account account)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
answered Nov 23 at 0:17
German Casares
726
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
add a comment |
FluentValidation works validating the entry parameters of the Endpoint. In your case this should work if you want to validate the Account from the body. If you want to validate the Query you have to write a QueryValidator.
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]Account account)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
answered Nov 23 at 0:17
German Casares
726
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
add a comment |
FluentValidation works validating the entry parameters of the Endpoint. In your case this should work if you want to validate the Account from the body. If you want to validate the Query you have to write a QueryValidator.
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]Account account)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
answered Nov 23 at 0:17
German Casares
726
FluentValidation works validating the entry parameters of the Endpoint. In your case this should work if you want to validate the Account from the body. If you want to validate the Query you have to write a QueryValidator.
[HttpPost]
public async Task<IActionResult> PostAsync([FromBody]Account account)
{
try
{
using (PerformanceTimer.StartNew("Performing GraphQL query", str=> LogHelper.Info(str)))
{
if (!ModelState.IsValid)
{
return null;
}
answered Nov 23 at 0:17
German Casares
726
edited Nov 23 at 0:20
answered Nov 23 at 0:17
German Casares
726
answered Nov 23 at 0:17
German Casares
726
answered Nov 23 at 0:17
German Casares
726
726
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
add a comment |
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I've tried this and I'm never getting modelstate as being invalid
– magna_nz
Nov 23 at 0:20
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
I have changed the answer. I misunderstood where you were using the Account.
– German Casares
Nov 23 at 16:22
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53439241%2ffluent-validation-not-validating-on-request%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
