Qfyilyi

Im relatively new to Actionscript3. I am trying to make a simple calculator that takes different values from the textbox objects on the stage and multiply them to give the result in other text boxes. I am trying this in Flash CS6. Screenshot of the .FLA file. How would I implement the following code using arrays?

    var txtbox:TextFormat=new TextFormat();

    txtbox.size = 11;

    txtbox.bold = true;



    value1.setStyle("textFormat",txtbox);

    value2.setStyle("textFormat",txtbox);

    value3.setStyle("textFormat",txtbox);

    value4.setStyle("textFormat",txtbox);

    value5.setStyle("textFormat",txtbox);

  multiplier.setStyle("textFormat",txtbox);



    result1.setStyle("textFormat",txtbox);

    result2.setStyle("textFormat",txtbox);

    result3.setStyle("textFormat",txtbox);

    result4.setStyle("textFormat",txtbox);

    result5.setStyle("textFormat",txtbox);





 compute.addEventListener(MouseEvent.CLICK, calBtn);

    function calBtn(event:MouseEvent):void

    {

         var myArray:Array = int(value1),int(value2),int(value3),int(value4),int(value5)];



var m:Number=Number(multiplier.text);



var r1:Number = int((value1*m)*1000)/1000;

var r2:Number = int((value2*m)*1000)/1000;

var r3:Number = int((value3*m)*1000)/1000;

var r4:Number = int((value4*m)*1000)/1000;

var r5:Number = int((value5*m)*1000)/1000;



result1.text=String(r1);

result2.text=String(r2);

result3.text=String(r3);

result4.text=String(r4);

result5.text=String(r5);

     }

The error you are getting is telling you that you're using a TextInput like it's a Number.

Looking through your code, we can see that is indeed what is happening:

int(value1)  //value1 presumably is a TextInput, and can't be converted to an int



//and later...

int((value1*m) //value1 is a TextInput, and can't be multiplied

What you need to do, is convert the text property of the TextInput into a Number first, then do your math. (just like you're currently doing with the multiplier text box)

int(value1.text) * m

There are few other issues with your code though, like how you're creating your array.
Here is a potential refactoring

var txtbox:TextFormat = new TextFormat();

    txtbox.size = 11;

    txtbox.bold = true;



//put all the text inputs and in an array so you don't have to repeat the same code so much

var textInputs:Array = [value1,value2,value3, value4, value5];

var textOutputs:Array = [result1, result2, result3, result4, result5];



//set the style in a for loop

for(var i:int=0;i<textInputs.length;i++){

    textInputs[i].setStyle("textFormat",txtbox);

}



multiplier.setStyle("textFormat",txtbox);



compute.addEventListener(MouseEvent.CLICK, calBtn);



function calBtn(event:MouseEvent):void

{

    var m:Number=Number(multiplier.text);

    //make sure the multiplier is a valid number

    if(isNaN(m)){

        //do something here to tell the user they entered something invalid

        return; //don't keep going in this function

    }



    //loop through each text input

    for(var i:int=0;i<textInputs.length;i++){

        //convert text input value to number

        var num:Number = int(textInputs[i].text);



        //check if the input is valid

        if(!isNaN(num)){

            textOutputs[i].text = String( (num * 1000) / 100 );

        }else{

            textOutputs[i].text = "Invalid Number";

        }

    }

 }

This problem is now solved. I have posted the code here so that others with a similar problem can use it as reference. I have also posted a screenshot of the result here.

var txtbox:TextFormat=new TextFormat();

txtbox.size = 11;

txtbox.bold = true;



var textInputs:Array = [value1,value2,value3,value4,value5];

var textOutputs:Array = [result1,result2,result3,result4,result5];



for (var i:Number=0; i<textInputs.length; i++)

{

    textInputs[i].setStyle("textFormat",txtbox);

}



multiplier.setStyle("textFormat",txtbox);



for (var j:Number=0; j<textOutputs.length; j++)

{

    textOutputs[j].setStyle("textFormat",txtbox);

}



compute.addEventListener(MouseEvent.CLICK, calBtn);

function calBtn(event:MouseEvent):void

{

    var m:Number=Number(multiplier.text);



for (var i:Number=0;i<textInputs.length;i++)

{

    var num:Number = Number(textInputs[i].text);

    textOutputs[i].text = String(int((num*m)*1000)/1000);

}

}