Using generic with Kotlin and MVP Android
up vote
0
down vote
favorite
I'm new to Kotlin and I started a new Android project using this language. From the beginning I faced some issues when a tried to make a schema of a MVP pattern in Kotlin using generic types. This is what I'm trying to accomplish:
AbstractBasePresenter.kt
abstract class AbstractBasePresenter<T: Any> internal constructor(
private val compositeDisposable: CompositeDisposable = CompositeDisposable()
) {
constructor() : this(CompositeDisposable())
private var view: T? = null
fun bind(view: T) {
if (this.view != null) throw IllegalStateException("view already bound")
this.view = view
afterBind()
}
fun unbind() {
if (this.view == null) throw IllegalStateException("view already unbound")
this.view = null
compositeDisposable.clear()
}
abstract fun afterBind()
protected fun addDisposable(disposable: Disposable): Disposable =
disposable.also {
compositeDisposable.add(it)
}
protected fun view(): T = view ?: throw IllegalStateException("view not bound")
}
BaseView.kt
interface BaseView<T : AbstractBasePresenter<*>> {
fun getPresenter(): T
}
AbstractBaseActivity
abstract class AbstractBaseActivity<T : AbstractBasePresenter<*>> : AppCompatActivity(), BaseView<T> {
override fun onStart() {
super.onStart()
getPresenter().bind(this)
}
override fun onStop() {
getPresenter().unbind()
super.onStop()
}
override fun startActivity(intent: Intent?) {
super.startActivity(intent)
slideInRight(this)
}
override fun onBackPressed() {
super.onBackPressed()
slideOutRight(this)
}
}
When I'm trying to use the base class I want something like bellow:
SplashActivity
class SplashActivity : AbstractBaseActivity<SplashPresenter>(), SplashActivityView {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.splash_activity)
}
override fun getPresenter(): SplashPresenter {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashPresenter
class SplashPresenter : AbstractBasePresenter<SplashActivityView>() {
override fun afterBind() {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashActivityView
interface SplashActivityView {
}
The idea is that this type of implementation is working fine in Java, but after the conversion it seems that with generic types from Kotlin I'm missing something and I got the following error in AbstractBaseActivity at binding the view:
**getPresenter().bind(this)** ------> "this" is underlined and I have the error: **"Type mismatch. Required nothing AbstractBaseActivity<T> found"**
Please tell me where I am doing things wrong or give me another type of solution to accomplish the actual BaseActivity scope (bind and unbing from a single place).
Thank you!
types required mismatch nothing
add a comment |
up vote
0
down vote
favorite
I'm new to Kotlin and I started a new Android project using this language. From the beginning I faced some issues when a tried to make a schema of a MVP pattern in Kotlin using generic types. This is what I'm trying to accomplish:
AbstractBasePresenter.kt
abstract class AbstractBasePresenter<T: Any> internal constructor(
private val compositeDisposable: CompositeDisposable = CompositeDisposable()
) {
constructor() : this(CompositeDisposable())
private var view: T? = null
fun bind(view: T) {
if (this.view != null) throw IllegalStateException("view already bound")
this.view = view
afterBind()
}
fun unbind() {
if (this.view == null) throw IllegalStateException("view already unbound")
this.view = null
compositeDisposable.clear()
}
abstract fun afterBind()
protected fun addDisposable(disposable: Disposable): Disposable =
disposable.also {
compositeDisposable.add(it)
}
protected fun view(): T = view ?: throw IllegalStateException("view not bound")
}
BaseView.kt
interface BaseView<T : AbstractBasePresenter<*>> {
fun getPresenter(): T
}
AbstractBaseActivity
abstract class AbstractBaseActivity<T : AbstractBasePresenter<*>> : AppCompatActivity(), BaseView<T> {
override fun onStart() {
super.onStart()
getPresenter().bind(this)
}
override fun onStop() {
getPresenter().unbind()
super.onStop()
}
override fun startActivity(intent: Intent?) {
super.startActivity(intent)
slideInRight(this)
}
override fun onBackPressed() {
super.onBackPressed()
slideOutRight(this)
}
}
When I'm trying to use the base class I want something like bellow:
SplashActivity
class SplashActivity : AbstractBaseActivity<SplashPresenter>(), SplashActivityView {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.splash_activity)
}
override fun getPresenter(): SplashPresenter {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashPresenter
class SplashPresenter : AbstractBasePresenter<SplashActivityView>() {
override fun afterBind() {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashActivityView
interface SplashActivityView {
}
The idea is that this type of implementation is working fine in Java, but after the conversion it seems that with generic types from Kotlin I'm missing something and I got the following error in AbstractBaseActivity at binding the view:
**getPresenter().bind(this)** ------> "this" is underlined and I have the error: **"Type mismatch. Required nothing AbstractBaseActivity<T> found"**
Please tell me where I am doing things wrong or give me another type of solution to accomplish the actual BaseActivity scope (bind and unbing from a single place).
Thank you!
types required mismatch nothing
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I'm new to Kotlin and I started a new Android project using this language. From the beginning I faced some issues when a tried to make a schema of a MVP pattern in Kotlin using generic types. This is what I'm trying to accomplish:
AbstractBasePresenter.kt
abstract class AbstractBasePresenter<T: Any> internal constructor(
private val compositeDisposable: CompositeDisposable = CompositeDisposable()
) {
constructor() : this(CompositeDisposable())
private var view: T? = null
fun bind(view: T) {
if (this.view != null) throw IllegalStateException("view already bound")
this.view = view
afterBind()
}
fun unbind() {
if (this.view == null) throw IllegalStateException("view already unbound")
this.view = null
compositeDisposable.clear()
}
abstract fun afterBind()
protected fun addDisposable(disposable: Disposable): Disposable =
disposable.also {
compositeDisposable.add(it)
}
protected fun view(): T = view ?: throw IllegalStateException("view not bound")
}
BaseView.kt
interface BaseView<T : AbstractBasePresenter<*>> {
fun getPresenter(): T
}
AbstractBaseActivity
abstract class AbstractBaseActivity<T : AbstractBasePresenter<*>> : AppCompatActivity(), BaseView<T> {
override fun onStart() {
super.onStart()
getPresenter().bind(this)
}
override fun onStop() {
getPresenter().unbind()
super.onStop()
}
override fun startActivity(intent: Intent?) {
super.startActivity(intent)
slideInRight(this)
}
override fun onBackPressed() {
super.onBackPressed()
slideOutRight(this)
}
}
When I'm trying to use the base class I want something like bellow:
SplashActivity
class SplashActivity : AbstractBaseActivity<SplashPresenter>(), SplashActivityView {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.splash_activity)
}
override fun getPresenter(): SplashPresenter {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashPresenter
class SplashPresenter : AbstractBasePresenter<SplashActivityView>() {
override fun afterBind() {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashActivityView
interface SplashActivityView {
}
The idea is that this type of implementation is working fine in Java, but after the conversion it seems that with generic types from Kotlin I'm missing something and I got the following error in AbstractBaseActivity at binding the view:
**getPresenter().bind(this)** ------> "this" is underlined and I have the error: **"Type mismatch. Required nothing AbstractBaseActivity<T> found"**
Please tell me where I am doing things wrong or give me another type of solution to accomplish the actual BaseActivity scope (bind and unbing from a single place).
Thank you!
types required mismatch nothing
I'm new to Kotlin and I started a new Android project using this language. From the beginning I faced some issues when a tried to make a schema of a MVP pattern in Kotlin using generic types. This is what I'm trying to accomplish:
AbstractBasePresenter.kt
abstract class AbstractBasePresenter<T: Any> internal constructor(
private val compositeDisposable: CompositeDisposable = CompositeDisposable()
) {
constructor() : this(CompositeDisposable())
private var view: T? = null
fun bind(view: T) {
if (this.view != null) throw IllegalStateException("view already bound")
this.view = view
afterBind()
}
fun unbind() {
if (this.view == null) throw IllegalStateException("view already unbound")
this.view = null
compositeDisposable.clear()
}
abstract fun afterBind()
protected fun addDisposable(disposable: Disposable): Disposable =
disposable.also {
compositeDisposable.add(it)
}
protected fun view(): T = view ?: throw IllegalStateException("view not bound")
}
BaseView.kt
interface BaseView<T : AbstractBasePresenter<*>> {
fun getPresenter(): T
}
AbstractBaseActivity
abstract class AbstractBaseActivity<T : AbstractBasePresenter<*>> : AppCompatActivity(), BaseView<T> {
override fun onStart() {
super.onStart()
getPresenter().bind(this)
}
override fun onStop() {
getPresenter().unbind()
super.onStop()
}
override fun startActivity(intent: Intent?) {
super.startActivity(intent)
slideInRight(this)
}
override fun onBackPressed() {
super.onBackPressed()
slideOutRight(this)
}
}
When I'm trying to use the base class I want something like bellow:
SplashActivity
class SplashActivity : AbstractBaseActivity<SplashPresenter>(), SplashActivityView {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.splash_activity)
}
override fun getPresenter(): SplashPresenter {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashPresenter
class SplashPresenter : AbstractBasePresenter<SplashActivityView>() {
override fun afterBind() {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
}
SplashActivityView
interface SplashActivityView {
}
The idea is that this type of implementation is working fine in Java, but after the conversion it seems that with generic types from Kotlin I'm missing something and I got the following error in AbstractBaseActivity at binding the view:
**getPresenter().bind(this)** ------> "this" is underlined and I have the error: **"Type mismatch. Required nothing AbstractBaseActivity<T> found"**
Please tell me where I am doing things wrong or give me another type of solution to accomplish the actual BaseActivity scope (bind and unbing from a single place).
Thank you!
types required mismatch nothing
types required mismatch nothing
asked Nov 22 at 15:55
mrRobot
11
11
add a comment |
add a comment |
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53434550%2fusing-generic-with-kotlin-and-mvp-android%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown