shared Button component disabled state
up vote
0
down vote
favorite
I have common Button component, I can control disabled state by passing props, like <Button disabled={loading} /> but if I have a parent on it, the onClick will not be stopped by the disabled attr on the button.
<div onClick={() => this.callSomething}><Button disabled={loading}></Button></div>
javascript reactjs
asked Nov 22 at 16:36
Peethi Avonas
245
add a comment |
up vote
0
down vote
favorite
I have common Button component, I can control disabled state by passing props, like <Button disabled={loading} /> but if I have a parent on it, the onClick will not be stopped by the disabled attr on the button.
<div onClick={() => this.callSomething}><Button disabled={loading}></Button></div>
javascript reactjs
asked Nov 22 at 16:36
Peethi Avonas
245
1
I believe thatonClickshould be used on button, not on the wrapper. And the button should has logic to block clicking if the state isdisable
– Dominik Krzywiecki
Nov 22 at 16:45
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
I have common Button component, I can control disabled state by passing props, like <Button disabled={loading} /> but if I have a parent on it, the onClick will not be stopped by the disabled attr on the button.
<div onClick={() => this.callSomething}><Button disabled={loading}></Button></div>
javascript reactjs
asked Nov 22 at 16:36
Peethi Avonas
245
I have common Button component, I can control disabled state by passing props, like <Button disabled={loading} /> but if I have a parent on it, the onClick will not be stopped by the disabled attr on the button.
<div onClick={() => this.callSomething}><Button disabled={loading}></Button></div>
javascript reactjs
javascript reactjs
asked Nov 22 at 16:36
Peethi Avonas
245
asked Nov 22 at 16:36
Peethi Avonas
245
asked Nov 22 at 16:36
Peethi Avonas
245
asked Nov 22 at 16:36
Peethi Avonas
245
asked Nov 22 at 16:36
Peethi Avonas
245
245
1
I believe thatonClickshould be used on button, not on the wrapper. And the button should has logic to block clicking if the state isdisable
– Dominik Krzywiecki
Nov 22 at 16:45
add a comment |
1
I believe thatonClickshould be used on button, not on the wrapper. And the button should has logic to block clicking if the state isdisable
– Dominik Krzywiecki
Nov 22 at 16:45
1
1
I believe that
onClick should be used on button, not on the wrapper. And the button should has logic to block clicking if the state is disable– Dominik Krzywiecki
Nov 22 at 16:45
I believe that
onClick should be used on button, not on the wrapper. And the button should has logic to block clicking if the state is disable– Dominik Krzywiecki
Nov 22 at 16:45
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435150%2fshared-button-component-disabled-state%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53435150%2fshared-button-component-disabled-state%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
I believe that
onClickshould be used on button, not on the wrapper. And the button should has logic to block clicking if the state isdisable– Dominik Krzywiecki
Nov 22 at 16:45