Qfyilyi

I am trying to run the following script using getopts to parse the options but it does not seem to work:

#!/bin/bash

set -x

echo $@

while getopts "rf" opt

do

  case "${opt}" in

    r)

        ropt=${OPTARG}

        ;;

    f)

        fopt=${OPTARG}

        ;;

  esac

done



shift $((OPTIND -1))



echo $fopt $ropt

The output I get is:

$ ./myscript.sh -f opt2 -r opt1

+ echo -f opt2 -r opt1

-f opt2 -r opt1

+ getopts rf opt

+ case "${opt}" in

+ fopt=

+ getopts rf opt

+ shift 1

+ echo



+ set +x

Do you have any ideas on what am I doing wrong?

You expect your options to take option-arguments, but you don't let getopts know about this.

You should use

while getopts "r:f:" opt; do ...; done

i.e., each option that takes an argument should have : after it in the argument string to getopts.

You'll probably also want a default case branch at the end to handle invalid options:

 *) usage >&2

    exit 1

(the error message (about invalid option or missing option argument) will be displayed by getopts itself, usage is expected to be a function that you will have defined that prints a short help message to standard output).

Also, don't forget to double quote all expansions, even $(( OPTIND - 1 )).

Related to that last point:

• When is double-quoting necessary?